Replace moribund cmake-format with gersemi
#169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes the CMake formatting infrastructure by replacing the moribund cmake-format tool with gersemi. The change simplifies the CI workflows by leveraging gersemi's built-in directory traversal capabilities, eliminating the need for manual file discovery logic.
- Introduces
.gersemircconfiguration file with explanatory comments about the tool's opinionated nature - Updates both check and fix workflows to use
gersemicommands - Removes complex bash scripts for file discovery in favor of gersemi's built-in directory scanning
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.gersemirc |
Adds configuration file for gersemi with comments explaining migration from cmake-format |
.github/workflows/cmake-format-check.yaml |
Replaces cmake-format check logic with simplified gersemi command |
.github/workflows/cmake-format-fix.yaml |
Replaces cmake-format apply logic with simplified gersemi command |
greenc-FNAL
added a commit
to greenc-FNAL/phlex
that referenced
this pull request
Dec 8, 2025
greenc-FNAL
added a commit
to greenc-FNAL/phlex
that referenced
this pull request
Dec 8, 2025
greenc-FNAL
added a commit
to greenc-FNAL/phlex
that referenced
this pull request
Dec 9, 2025
greenc-FNAL
added a commit
to greenc-FNAL/phlex
that referenced
this pull request
Dec 9, 2025
greenc-FNAL
force-pushed
the
feat-replace-cmake-format-with-gersemi
branch
from
f372cd9 to
be633c5
Compare
Contributor
Author
|
@phlexbot format |
Contributor
|
No automatic fixes were necessary. |
1 similar comment
Contributor
|
No automatic fixes were necessary. |
greenc-FNAL
added a commit
to greenc-FNAL/phlex
that referenced
this pull request
Dec 11, 2025
greenc-FNAL
added a commit
to greenc-FNAL/phlex
that referenced
this pull request
Dec 11, 2025
greenc-FNAL
added a commit
to greenc-FNAL/phlex
that referenced
this pull request
Jan 5, 2026
greenc-FNAL
added a commit
to greenc-FNAL/phlex
that referenced
this pull request
Jan 5, 2026
greenc-FNAL
added a commit
to greenc-FNAL/phlex
that referenced
this pull request
Jan 6, 2026
greenc-FNAL
added a commit
to greenc-FNAL/phlex
that referenced
this pull request
Jan 6, 2026
greenc-FNAL
force-pushed
the
feat-replace-cmake-format-with-gersemi
branch
from
be633c5 to
46109ae
Compare
knoepfel
reviewed
Jan 7, 2026
Member
knoepfel
left a comment
knoepfel
left a comment
There was a problem hiding this comment.
Thanks, @greenc-FNAL, for the PR. Just a couple comments below.
greenc-FNAL
added a commit
to greenc-FNAL/phlex
that referenced
this pull request
Jan 7, 2026
greenc-FNAL
added a commit
to greenc-FNAL/phlex
that referenced
this pull request
Jan 7, 2026
greenc-FNAL
force-pushed
the
feat-replace-cmake-format-with-gersemi
branch
from
46109ae to
6cfe181
Compare
…nstead of `cmake-format`. The following changes have been made: - A new `.gersemirc` configuration file has been added. - The `cmake-format-check.yaml` workflow has been updated to use `gersemi --check`. - The `cmake-format-fix.yaml` workflow has been updated to use `gersemi --in-place`. The new implementation simplifies the workflow scripts by removing the need for a manual file search, relying instead on `gersemi`'s built-in directory traversal.
greenc-FNAL
force-pushed
the
feat-replace-cmake-format-with-gersemi
branch
from
6cfe181 to
8581582
Compare
Contributor
Author
|
@knoepfel It seems like I might have unintentionally mixed in some changes I was looking at to enable invocation of some workflows from Cetmodules CI. I think I've managed to extract them. |
knoepfel
approved these changes
Jan 8, 2026
Member
|
LGTM. Once this one is merged, are you able to submit a PR that applies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes have been made:
.gersemircconfiguration file has been added.cmake-format-check.yamlworkflow has been updated to usegersemi --check.cmake-format-fix.yamlworkflow has been updated to usegersemi --in-place.The new implementation simplifies the workflow scripts by removing the need for a manual file search, relying instead on
gersemi's built-in directory traversal.